feat: warning if run in job #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@johanneskoester I think this is a rather trivial change - however, I do not know how to extend the test suite for it. Pointers? Or can it be merged like that? |
|
@johanneskoester I consider this an urgent PR - there are always people you try something like this. |
|
waited long enough |
cmeesters
pushed a commit
that referenced
this pull request
Jun 25, 2024
🤖 I have created a release *beep* *boop* --- ## [0.7.0](v0.6.0...v0.7.0) (2024-06-25) ### Features * warning if run in job ([#78](#78)) ([257e830](257e830)) ### Bug Fixes * null byte account guess ([#81](#81)) ([92d4445](92d4445)) ### Documentation * added mini paragraph about Conda and Env Modules ([#42](#42)) ([c821b5e](c821b5e)) * added paragraphs about dynamic resource allocation ([#79](#79)) ([06a1555](06a1555)) * storage update ([#80](#80)) ([7e19560](7e19560)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
cmeesters
added a commit
that referenced
this pull request
Jul 5, 2024
Already, two issues (#75 and #22) seem to result from running Snakemake in a SLURM job context and using this executor plugin. This PR introduces detecting if triggered within a SLURM job and issuing a warning accordingly. In principle, the plugin may work in job context. Submitting jobs from jobs has always been a highlight of SLURM. However, settings may lead to unintended behaviour (and would do so without Snakemake, presumably). Hence, we can only warn from the executor.
cmeesters
pushed a commit
that referenced
this pull request
Jul 5, 2024
🤖 I have created a release *beep* *boop* --- ## [0.7.0](v0.6.0...v0.7.0) (2024-06-25) ### Features * warning if run in job ([#78](#78)) ([257e830](257e830)) ### Bug Fixes * null byte account guess ([#81](#81)) ([92d4445](92d4445)) ### Documentation * added mini paragraph about Conda and Env Modules ([#42](#42)) ([c821b5e](c821b5e)) * added paragraphs about dynamic resource allocation ([#79](#79)) ([06a1555](06a1555)) * storage update ([#80](#80)) ([7e19560](7e19560)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
cmeesters
added a commit
that referenced
this pull request
Jul 12, 2024
Already, two issues (#75 and #22) seem to result from running Snakemake in a SLURM job context and using this executor plugin. This PR introduces detecting if triggered within a SLURM job and issuing a warning accordingly. In principle, the plugin may work in job context. Submitting jobs from jobs has always been a highlight of SLURM. However, settings may lead to unintended behaviour (and would do so without Snakemake, presumably). Hence, we can only warn from the executor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Already, two issues (#75 and #22) seem to result from running Snakemake in a SLURM job context and using this executor plugin. This PR introduces detecting if triggered within a SLURM job and issuing a warning accordingly.
In principle, the plugin may work in job context. Submitting jobs from jobs has always been a highlight of SLURM. However, settings may lead to unintended behaviour (and would do so without Snakemake, presumably). Hence, we can only warn from the executor.